Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Installation]: Avoid ModuleNotFound:setuptools-scm error #476

Open
wants to merge 1 commit into
base: habana_upstream
Choose a base branch
from
Open

[Installation]: Avoid ModuleNotFound:setuptools-scm error #476

wants to merge 1 commit into from

Conversation

MohitIntel
Copy link

@MohitIntel MohitIntel commented Nov 7, 2024 •
edited
Loading

Current instructions for setup using standalone docker (not using Dockerfile) is missing the pip install -r requirements-hpu.txt instruction. A new user using this method for setup will encounter :

File "/root/vllm/setup.py", line 15, in <module>
    from setuptools_scm import get_version
ModuleNotFoundError: No module named 'setuptools_scm'

This PR fixes that.

michalkuligowski
michalkuligowski requested changes Nov 7, 2024
View reviewed changes
Copy link

@michalkuligowski michalkuligowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to README_GAUDI.md also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkuligowski michalkuligowski michalkuligowski requested changes

@mgawarkiewicz mgawarkiewicz Awaiting requested review from mgawarkiewicz

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel

@tzielinski-habana tzielinski-habana Awaiting requested review from tzielinski-habana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MohitIntel @michalkuligowski